Harden logic when looking for syslog entries for failing test#15841
Merged
Merged
Harden logic when looking for syslog entries for failing test#15841
Conversation
iSazonov
approved these changes
Jul 29, 2021
rjmholt
reviewed
Jul 29, 2021
Comment on lines
+256
to
+259
| $items = Get-PSSysLog -Path $SyslogFile | ||
| @($items).Count | Should -BeGreaterThan 0 | ||
| $logs = $items | Where-Object { $_.ProcessId -eq $result } | ||
| $logs | Should -BeNullOrEmpty |
Collaborator
There was a problem hiding this comment.
It looks like the test previously assumed there would be no entries, but now we expect some entries but none with the PID data. What's changed?
Member
There was a problem hiding this comment.
I think this was added to make it more robust.
adityapatwardhan
approved these changes
Jul 29, 2021
|
🎉 Handy links: |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Change and harden the logic when determining whether a syslog entry has been made. Rather than using the logid, I am determining whether or not a particular PID shows up as a syslog entry. This is a fix for #15814.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).