Fix CA1052 in TypeCatalogGen#15840
Merged
Merged
Fix CA1052 in TypeCatalogGen#15840
CA1052 in TypeCatalogGen#15840Conversation
iSazonov
approved these changes
Jul 29, 2021
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
TravisEz13
approved these changes
Aug 5, 2021
Member
|
This is a tool not part of PowerShell, so not a breaking change |
|
🎉 Handy links: |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft.PowerShell.CoreCLR.TypeCatalogGenTreatWarningsAsErrorsforTypeCatalogGen.csprojIn #15775, we missed a warning as
TreatWarningsAsErrorswas not enabled.Again, possible breaking public API change (Unlikely Grey Area), however instantiating the class has no obvious utility and furthermore the API doesn't appear to be publicly documented.