WIP: Don't specify paramName for ArgumentNullException in properties#15720
Closed
xtqqczze wants to merge 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:fix-ArgumentNullException2xtqqczze/PowerShell-PowerShell:fix-ArgumentNullException2Copy head branch name to clipboard
Closed
WIP: Don't specify paramName for ArgumentNullException in properties#15720xtqqczze wants to merge 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom xtqqczze:fix-ArgumentNullException2xtqqczze/PowerShell-PowerShell:fix-ArgumentNullException2Copy head branch name to clipboard
paramName for ArgumentNullException in properties#15720xtqqczze wants to merge 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:fix-ArgumentNullException2xtqqczze/PowerShell-PowerShell:fix-ArgumentNullException2Copy head branch name to clipboard
Conversation
Contributor
Author
|
CodeFactor "complex method" new issues are false positives, issue opened: #15721. |
Collaborator
|
@xtqqczze Please add more information in the PR description for reviewers why we need the changes.. |
Contributor
Author
|
However, Framework Design Guidelines (2008) from Addison-Wesley Microsoft Technology Series recommend this pattern:
|
Contributor
Author
|
Removing the Issue opened: dotnet/roslyn-analyzers#5209. |
paramName for ArgumentNullException in propertiesparamName for ArgumentNullException in properties
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifying
valueas aparamNameforArgumentExceptionin properties does not add any value over the stack trace.Follow-up to #15604 (comment).