Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix HyperVSocketEndPoint.ServiceId setter#15704

Merged
iSazonov merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:fix-HyperVSocketEndPointxtqqczze/PowerShell-PowerShell:fix-HyperVSocketEndPointCopy head branch name to clipboard
Jul 7, 2021
Merged

Fix HyperVSocketEndPoint.ServiceId setter#15704
iSazonov merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:fix-HyperVSocketEndPointxtqqczze/PowerShell-PowerShell:fix-HyperVSocketEndPointCopy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jul 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

cc: @PaulHigin

Fix #13995.

@ghost ghost assigned anmenaga Jul 1, 2021
@xtqqczze xtqqczze mentioned this pull request Jul 1, 2021
Merged
@iSazonov iSazonov requested review from PaulHigin and SteveL-MSFT July 1, 2021 03:05
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 1, 2021
@iSazonov

iSazonov commented Jul 1, 2021

Copy link
Copy Markdown
Collaborator

@SteveL-MSFT Could you please ask anybody from HyperV team to review this?

PaulHigin
PaulHigin approved these changes Jul 1, 2021
View reviewed changes

@PaulHigin PaulHigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xtqqczze xtqqczze changed the title Fix HyperVSocketEndPoint .ServiceId setter Fix HyperVSocketEndPoint.ServiceId setter Jul 2, 2021
@xtqqczze xtqqczze force-pushed the fix-HyperVSocketEndPoint branch from 1c9f6fc to de18a76 Compare July 7, 2021 06:31
@xtqqczze

xtqqczze commented Jul 7, 2021

Copy link
Copy Markdown
Contributor Author

Rebased onto #13880, and suppression removed.

@iSazonov iSazonov merged commit acb4c4a into PowerShell:master Jul 7, 2021
@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Jul 7, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jul 7, 2021
@xtqqczze xtqqczze deleted the fix-HyperVSocketEndPoint branch July 8, 2021 00:09
@ghost

ghost commented Jul 22, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jul 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

+2 more reviewers

@PaulHigin PaulHigin PaulHigin approved these changes

@vexx32 vexx32 vexx32 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.8

Development

Successfully merging this pull request may close these issues.

Property setter assigning to field in HyperVSocketEndPoint

5 participants

@xtqqczze @iSazonov @PaulHigin @vexx32 @anmenaga
Morty Proxy This is a proxified and sanitized view of the page, visit original site.