Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enhance Remove-Item to work with OneDrive (Third)#15571

Merged
rjmholt merged 11 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:isreparsepointlikesymlink3iSazonov/PowerShell:isreparsepointlikesymlink3Copy head branch name to clipboard
Aug 5, 2021
Merged

Enhance Remove-Item to work with OneDrive (Third)#15571
rjmholt merged 11 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:isreparsepointlikesymlink3iSazonov/PowerShell:isreparsepointlikesymlink3Copy head branch name to clipboard

Conversation

@iSazonov

@iSazonov iSazonov commented Jun 13, 2021

Copy link
Copy Markdown
Collaborator

PR Summary

Fix #15466

Continue #15260

EnsureExtendedPrefix is copy-pasted from .Net Runtime repository.

PR Context

PR Checklist

@ghost ghost assigned daxian-dbw Jun 13, 2021
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jun 13, 2021
@iSazonov iSazonov assigned rjmholt and unassigned daxian-dbw Jun 13, 2021
@iSazonov iSazonov requested review from rjmholt and rkeithhill June 13, 2021 04:34
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
@iSazonov

Copy link
Copy Markdown
Collaborator Author

@rjmholt Friendly ping :-)

@ghost ghost added the Review - Needed The PR is being reviewed label Jun 25, 2021
@ghost

ghost commented Jun 25, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Comment thread src/System.Management.Automation/engine/Utils.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Comment thread src/System.Management.Automation/utils/PathUtils.cs Outdated
Comment thread src/System.Management.Automation/utils/PathUtils.cs Outdated
Comment thread src/System.Management.Automation/utils/PathUtils.cs Outdated
@iSazonov iSazonov force-pushed the isreparsepointlikesymlink3 branch from 35ebe2c to b28f930 Compare July 27, 2021 06:04
@rjmholt

rjmholt commented Jul 27, 2021

Copy link
Copy Markdown
Collaborator

@iSazonov please add comments around code that's been copy/pasted from .NET about where it's come from

@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 27, 2021
@iSazonov

Copy link
Copy Markdown
Collaborator Author

@iSazonov please add comments around code that's been copy/pasted from .NET about where it's come from

There is already #region Helpers for long paths from .Net Runtime.

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 4, 2021
@ghost

ghost commented Aug 4, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@rjmholt

rjmholt commented Aug 5, 2021

Copy link
Copy Markdown
Collaborator

/azp run

@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 5, 2021
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 6 pipeline(s).

Comment thread src/System.Management.Automation/utils/PathUtils.cs
Comment thread src/System.Management.Automation/engine/Utils.cs Outdated
Co-authored-by: Steve Lee <slee@microsoft.com>
Comment thread src/System.Management.Automation/engine/Utils.cs Outdated
Comment thread src/System.Management.Automation/engine/Utils.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Co-authored-by: Steve Lee <slee@microsoft.com>
@rjmholt

rjmholt commented Aug 5, 2021

Copy link
Copy Markdown
Collaborator

@PoshChan please remind me in 1 hour

Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs
@rjmholt rjmholt enabled auto-merge (squash) August 5, 2021 17:39
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
@PoshChan

PoshChan commented Aug 5, 2021

Copy link
Copy Markdown
Collaborator

@rjmholt, this is the reminder you requested 1 hour ago

@rjmholt rjmholt merged commit 45adfee into PowerShell:master Aug 5, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.9 milestone Aug 5, 2021
@iSazonov iSazonov deleted the isreparsepointlikesymlink3 branch August 5, 2021 18:46
@ghost

ghost commented Aug 23, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

ghost commented Sep 28, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove-Item does not work correctly with long paths

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.