Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Change minimum depth to 0 for ConvertTo-Json#14830

Merged
TravisEz13 merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
kvprasoon:jsondepthkvprasoon/PowerShell:jsondepthCopy head branch name to clipboard
Apr 8, 2021
Merged

Change minimum depth to 0 for ConvertTo-Json#14830
TravisEz13 merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
kvprasoon:jsondepthkvprasoon/PowerShell:jsondepthCopy head branch name to clipboard

Conversation

@kvprasoon

@kvprasoon kvprasoon commented Feb 17, 2021

Copy link
Copy Markdown
Contributor

Recreating PR #13700

PR Summary

Change min depth to 0 for ConvertTo-Json

Related to: #13660

PR Checklist

@ghost ghost assigned iSazonov Feb 17, 2021
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 18, 2021
@kvprasoon

Copy link
Copy Markdown
Contributor Author

Cc: @TravisEz13

@ghost ghost added the Review - Needed The PR is being reviewed label Feb 27, 2021
@ghost

ghost commented Feb 27, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13

Copy link
Copy Markdown
Member

@SteveL-MSFT can you code review this?

@ghost ghost removed the Review - Needed The PR is being reviewed label Mar 13, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Mar 20, 2021
@ghost

ghost commented Mar 20, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13

Copy link
Copy Markdown
Member

What is the purpose of a 0 depth?

@ghost ghost removed the Review - Needed The PR is being reviewed label Mar 21, 2021
@TravisEz13

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@TravisEz13

This comment has been minimized.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kvprasoon

kvprasoon commented Mar 22, 2021

Copy link
Copy Markdown
Contributor Author

What is the purpose of a 0 depth?

I've updated the summary from old PR. Its based on #13660

@iSazonov

Copy link
Copy Markdown
Collaborator

@kvprasoon Is there an related issue to add in the description?

@kvprasoon

Copy link
Copy Markdown
Contributor Author

@iSazonov Yes. Its already there in PRSummary

@iSazonov

Copy link
Copy Markdown
Collaborator

@iSazonov Yes. Its already there in PR Summary

I don't see :-(

@vexx32

vexx32 commented Mar 22, 2021

Copy link
Copy Markdown
Collaborator

Related issue is #13660

@kvprasoon

Copy link
Copy Markdown
Contributor Author

I don't see :-(

PR CheckList actually, ;-).

@TravisEz13

Copy link
Copy Markdown
Member

In your doc issue you describe the behavior of depth 2. Not depth 0. I see no need for this PR.

@kvprasoon

Copy link
Copy Markdown
Contributor Author

Actually I'm not the one who raised the issue. But I support that issue and hence created the PR.
If not value. Then I am okay to close this :-).

@vexx32

vexx32 commented Mar 22, 2021

Copy link
Copy Markdown
Collaborator

This comment shows the need for this: #13660 (comment)

Basically it forces the json to a "flat" object. There's no reason not to allow this, and although it may be considered edge case for some, I see no reason to force folks to find weird workaround when we can just fix it. 🙂

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 24, 2021
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 4, 2021
@TravisEz13 TravisEz13 changed the title Change min depth to 0 for ConvertTo-Json Change minimum depth to 0 for ConvertTo-Json Apr 8, 2021
@TravisEz13 TravisEz13 merged commit 837c3e8 into PowerShell:master Apr 8, 2021
@TravisEz13 TravisEz13 added this to the 7.2.0-preview.5 milestone Apr 8, 2021
@ghost

ghost commented Apr 14, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

TravisEz13 added a commit that referenced this pull request Apr 16, 2021
[7.2.0-preview.5] - 2021-04-14

* Breaking Changes

- Make PowerShell Linux deb and RPM packages universal (#15109)
- Enforce AppLocker Deny configuration before Execution Policy Bypass configuration (#15035)
- Disallow mixed dash and slash in command line parameter prefix (#15142) (Thanks @davidBar-On!)

* Experimental Features

- `PSNativeCommandArgumentPassing`: Use `ArgumentList` for native executable invocation (breaking change) (#14692)

* Engine Updates and Fixes

- Add `IArgumentCompleterFactory` for parameterized `ArgumentCompleters` (#12605) (Thanks @powercode!)

* General Cmdlet Updates and Fixes

- Fix SSH remoting connection never finishing with misconfigured endpoint (#15175)
- Respect `TERM` and `NO_COLOR` environment variables for `$PSStyle` rendering (#14969)
- Use `ProgressView.Classic` when Virtual Terminal is not supported (#15048)
- Fix `Get-Counter` issue with `-Computer` parameter (#15166) (Thanks @krishnayalavarthi!)
- Fix redundant iteration while splitting lines (#14851) (Thanks @hez2010!)
- Enhance `Remove-Item -Recurse` to work with OneDrive (#14902) (Thanks @iSazonov!)
- Change minimum depth to 0 for `ConvertTo-Json` (#14830) (Thanks @kvprasoon!)
- Allow `Set-Clipboard` to accept empty string (#14579)
- Turn on and off `DECCKM` to modify keyboard mode for Unix native commands to work correctly (#14943)
- Fall back to `CopyAndDelete()` when `MoveTo()` fails due to an `IOException` (#15077)

* Code Cleanup

<details>

<summary>

<p>We thank the following contributors!</p>
<p>@xtqqczze, @iSazonov, @ZhiZe-ZG</p>

</summary>

<ul>
<li>Update .NET to <code>6.0.0-preview.3</code> (#15221)</li>
<li>Add space before comma to hosting test to fix error reported by <code>SA1001</code> (#15224)</li>
<li>Add <code>SecureStringHelper.FromPlainTextString</code> helper method for efficient secure string creation (#14124) (Thanks @xtqqczze!)</li>
<li>Use static lambda keyword (#15154) (Thanks @iSazonov!)</li>
<li>Remove unnecessary <code>Array</code> -&gt; <code>List</code> -&gt; <code>Array</code> conversion in <code>ProcessBaseCommand.AllProcesses</code> (#15052) (Thanks @xtqqczze!)</li>
<li>Standardize grammar comments in Parser.cs (#15114) (Thanks @ZhiZe-ZG!)</li>
<li>Enable <code>SA1001</code>: Commas should be spaced correctly (#14171) (Thanks @xtqqczze!)</li>
<li>Refactor <code>MultipleServiceCommandBase.AllServices</code> (#15053) (Thanks @xtqqczze!)</li>
</ul>

</details>

* Tools

- Use Unix line endings for shell scripts (#15180) (Thanks @xtqqczze!)

* Tests

- Add the missing tag in Host Utilities tests (#14983)
- Update `copy-props` version in `package.json` (#15124)

* Build and Packaging Improvements

<details>

<summary>

<p>We thank the following contributors!</p>
<p>@JustinGrote</p>

</summary>

<ul>
<li>Fix <code>yarn-lock</code> for <code>copy-props</code> (#15225)</li>
<li>Make package validation regex accept universal Linux packages (#15226)</li>
<li>Bump NJsonSchema from 10.4.0 to 10.4.1 (#15190)</li>
<li>Make MSI and EXE signing always copy to fix daily build (#15191)</li>
<li>Sign internals of EXE package so that it works correctly when signed (#15132)</li>
<li>Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4 (#15141)</li>
<li>Update daily release tag format to  work with new Microsoft Update work (#15164)</li>
<li>Feature: Add Ubuntu 20.04 Support to install-powershell.sh (#15095) (Thanks @JustinGrote!)</li>
<li>Treat rebuild branches like release branches (#15099)</li>
<li>Update WiX to 3.11.2 (#15097)</li>
<li>Bump NJsonSchema from 10.3.11 to 10.4.0 (#15092)</li>
<li>Allow patching of preview releases (#15074)</li>
<li>Bump Newtonsoft.Json from 12.0.3 to 13.0.1 (#15084, #15085)</li>
<li>Update the <code>minSize</code> build package filter to be explicit (#15055)</li>
<li>Bump NJsonSchema from 10.3.10 to 10.3.11 (#14965)</li>
</ul>

</details>

* Documentation and Help Content

- Merge `7.2.0-preview.4` changes to master (#15056)
- Update `README` and `metadata.json` (#15046)
- Fix broken links for `dotnet` CLI (#14937)

[7.2.0-preview.5]: v7.2.0-preview.4...v7.2.0-preview.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.