Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix syntax error in Windows packaging script#14377

Merged
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
rjmholt:fix-windows-pkgingrjmholt/PowerShell:fix-windows-pkgingCopy head branch name to clipboard
Dec 10, 2020
Merged

Fix syntax error in Windows packaging script#14377
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
rjmholt:fix-windows-pkgingrjmholt/PowerShell:fix-windows-pkgingCopy head branch name to clipboard

Conversation

@rjmholt

@rjmholt rjmholt commented Dec 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes a parse error in the Windows packaging automation caused by #14090.

PR Context

PR Checklist

@ghost ghost assigned iSazonov Dec 10, 2020
@rjmholt rjmholt assigned TravisEz13 and rjmholt and unassigned iSazonov and TravisEz13 Dec 10, 2020
@rjmholt

rjmholt commented Dec 10, 2020

Copy link
Copy Markdown
Collaborator Author

@PoshChan please remind me 2 hours

@PoshChan

PoshChan commented Dec 10, 2020

Copy link
Copy Markdown
Collaborator

@rjmholt, I do not understand: please remind me 2 hours

Commands available in this repo for you:
  • retry <target> this will attempt to retry only the failed jobs for the target pipeline, restart can be used in place of retry
  • rebuild <target> this will perform a complete rebuild of the target pipeline, rerun can be used in place of rebuild Supported values for <target> which can be a comma separated list are: static,windows,macos,linux,ssh,all
  • get failures this will attempt to get the latest failures for all of the target pipelines
  • remind me in <value> <units> this will create a reminder that will be posted after the specified duration <value> is a number, and <units> can be minutes, hours, or days (singular or plural)

@rjmholt

rjmholt commented Dec 10, 2020

Copy link
Copy Markdown
Collaborator Author

@PoshChan please remind me in 2 hours

@TravisEz13 TravisEz13 assigned TravisEz13 and unassigned rjmholt Dec 10, 2020
@TravisEz13 TravisEz13 merged commit 9d50a05 into PowerShell:master Dec 10, 2020
@rjmholt rjmholt deleted the fix-windows-pkging branch December 10, 2020 21:46
@PoshChan

PoshChan commented Dec 10, 2020

Copy link
Copy Markdown
Collaborator

@rjmholt, this is the reminder you requested 2 hours ago

@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 11, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 11, 2020
@ghost

ghost commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

TravisEz13 pushed a commit that referenced this pull request Dec 16, 2020
@rjmholt @TravisEz13
Fix syntax error in Windows packaging script (#14377)
88478d6 
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-packaging.yml
@TravisEz13 TravisEz13 added Backport-7.1.x-Done Backport to 7.1.x completed and removed BackPort-7.1.x-Approved labels Dec 16, 2020
TravisEz13 pushed a commit that referenced this pull request Dec 16, 2020
@rjmholt @TravisEz13
Fix syntax error in Windows packaging script (#14377)
411f48c 
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-packaging.yml
rjmholt added a commit to rjmholt/PowerShell that referenced this pull request Jan 12, 2021
@rjmholt @TravisEz13
Fix syntax error in Windows packaging script (PowerShell#14377)
678cd0c 
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-packaging.yml
@ghost

ghost commented Jan 14, 2021

Copy link
Copy Markdown

🎉v7.1.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

ghost commented Jan 19, 2021

Copy link
Copy Markdown

🎉v7.0.4 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 TravisEz13

Labels

Backport-7.0.x-Done Backport-7.1.x-Done Backport to 7.1.x completed CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

5 participants

@rjmholt @PoshChan @TravisEz13 @SteveL-MSFT @iSazonov
Morty Proxy This is a proxified and sanitized view of the page, visit original site.