Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Upgrade StyleCopAnalyzers to v1.2.0-beta.312#14354

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:upgrade-stylecopxtqqczze/PowerShell-PowerShell:upgrade-stylecopCopy head branch name to clipboard
Dec 12, 2020
Merged

Upgrade StyleCopAnalyzers to v1.2.0-beta.312#14354
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:upgrade-stylecopxtqqczze/PowerShell-PowerShell:upgrade-stylecopCopy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Dec 8, 2020

Copy link
Copy Markdown
Contributor

@ghost ghost assigned daxian-dbw Dec 8, 2020
@xtqqczze xtqqczze mentioned this pull request Dec 8, 2020
Closed
@xtqqczze

xtqqczze commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

@iSazonov Could you please approve changes.

@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Dec 9, 2020
@xtqqczze

xtqqczze commented Dec 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@iSazonov @RDIL I asked about using dependabot for StyleCopAnalyzers at dotnet/runtime#45779.

@iSazonov

iSazonov commented Dec 9, 2020

Copy link
Copy Markdown
Collaborator

@iSazonov @RDIL I asked about using dependabot for StyleCopAnalyzers at dotnet/runtime#45779.

They are large team and they can track manually.

We don't configure dependabot to auto-merge so I am ok if dependabot will create new PRs but only if new versions are not released frequently (monthly?).

@xtqqczze

xtqqczze commented Dec 9, 2020 •
edited by unfurl-links Bot
Loading

Copy link
Copy Markdown
Contributor Author

@iSazonov @RDIL I asked about using dependabot for StyleCopAnalyzers at dotnet/runtime#45779.

They are large team and they can track manually.

We don't configure dependabot to auto-merge so I am ok if dependabot will create new PRs but only if new versions are not released frequently (monthly?).

I think releases may be more frequent until C# 9.0 support is complete. But generally releases happen less often, see https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases.

GitHub
An implementation of StyleCop rules using the .NET Compiler Platform - DotNetAnalyzers/StyleCopAnalyzers

@daxian-dbw daxian-dbw merged commit 41cfc4e into PowerShell:master Dec 12, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 12, 2020
@xtqqczze xtqqczze deleted the upgrade-stylecop branch December 12, 2020 13:53
@ghost

ghost commented Feb 12, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Steg17
Steg17 reviewed Feb 21, 2021
View reviewed changes

@Steg17 Steg17 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+1 more reviewer

@Steg17 Steg17 Steg17 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@daxian-dbw daxian-dbw

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

4 participants

@xtqqczze @iSazonov @daxian-dbw @Steg17
Morty Proxy This is a proxified and sanitized view of the page, visit original site.