Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Replace GetFiles in TestModuleManifestCommand#14317

Merged
rjmholt merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:GetFiles-TestModuleManifestCommandxtqqczze/PowerShell-PowerShell:GetFiles-TestModuleManifestCommandCopy head branch name to clipboard
Dec 9, 2020
Merged

Replace GetFiles in TestModuleManifestCommand#14317
rjmholt merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:GetFiles-TestModuleManifestCommandxtqqczze/PowerShell-PowerShell:GetFiles-TestModuleManifestCommandCopy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

PR Summary

  • Replace GetFiles with EnumerateFiles to avoid large array allocation.
  • Simplify if-return

PR Context

Contributes to #14318.

PR Checklist

* Replace GetFiles with EnumerateFiles to avoid large array allocation.
* Simplify if-return
@rjmholt rjmholt requested a review from daxian-dbw December 4, 2020 17:01
@rjmholt rjmholt added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 9, 2020
@rjmholt rjmholt merged commit f74acaa into PowerShell:master Dec 9, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 9, 2020
@xtqqczze xtqqczze deleted the GetFiles-TestModuleManifestCommand branch December 9, 2020 20:29
@ghost

ghost commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.