Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Disable SA1000: Keywords should be spaced correctly#14292

Closed
xtqqczze wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:revert-SA1000xtqqczze/PowerShell-PowerShell:revert-SA1000Copy head branch name to clipboard
Closed

Disable SA1000: Keywords should be spaced correctly#14292
xtqqczze wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:revert-SA1000xtqqczze/PowerShell-PowerShell:revert-SA1000Copy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 30, 2020

Copy link
Copy Markdown
Contributor

Disable SA1000 analyzer that was enabled in #13973 because the StyleCopAnalyzers version does not recognise target-typed new expressions.

@ghost ghost assigned iSazonov Nov 30, 2020
@xtqqczze

Copy link
Copy Markdown
Contributor Author

@iSazonov Please merge ASAP.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

I'm seeing warnings on the following pattern in live analysis, I'm surprised CI did not fail:

SA1000: The keyword 'new' should be followed by a space.

This issue was fixed in DotNetAnalyzers/StyleCopAnalyzers#3187, and is in the v1.2.0-beta.261 release.

Originally posted by @xtqqczze in #13973 (comment)

@xtqqczze

Copy link
Copy Markdown
Contributor Author

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Closed in favour of #14297.

@xtqqczze xtqqczze closed this Nov 30, 2020
@xtqqczze xtqqczze deleted the revert-SA1000 branch November 30, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.