Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix whitespace issues#14092

Merged
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:fix-whitespacextqqczze/PowerShell-PowerShell:fix-whitespaceCopy head branch name to clipboard
Nov 19, 2020
Merged

Fix whitespace issues#14092
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:fix-whitespacextqqczze/PowerShell-PowerShell:fix-whitespaceCopy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 14, 2020

Copy link
Copy Markdown
Contributor

Fix some whitespace issues using dotnet-format

@xtqqczze xtqqczze requested a review from anmenaga as a code owner November 14, 2020 01:47
@ghost ghost assigned TravisEz13 Nov 14, 2020
@xtqqczze

Copy link
Copy Markdown
Contributor Author

@iSazonov Please could you merge.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Test failures due to HTTP error 503 (Service Unavailable) in package restore. Since these are trivial changes, I will not restart tests.

@iSazonov

iSazonov commented Nov 14, 2020

Copy link
Copy Markdown
Collaborator

@xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

GitHub
PowerShell for every system! Contribute to iSazonov/PowerShell development by creating an account on GitHub.

@xtqqczze

xtqqczze commented Nov 15, 2020

Copy link
Copy Markdown
Contributor Author

@xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

Yep looks likes a conflict between #13496 and #13872, TestPriority is now named Priority.

@xtqqczze

xtqqczze commented Nov 15, 2020

Copy link
Copy Markdown
Contributor Author

@xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

Yep looks likes a conflict between #13496 and #13872, TestPriority is now named Priority.

Fix merged in #14094.

@iSazonov

Copy link
Copy Markdown
Collaborator

@xtqqczze Please rebase.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

@iSazonov Pleases merge.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 19, 2020
@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Nov 19, 2020
@iSazonov iSazonov merged commit c9df1c1 into PowerShell:master Nov 19, 2020
@xtqqczze xtqqczze deleted the fix-whitespace branch November 19, 2020 11:44
@ghost

ghost commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.