Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enable IDE0075: SimplifyConditionalExpression#14078

Merged
iSazonov merged 5 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:IDE0075xtqqczze/PowerShell-PowerShell:IDE0075Copy head branch name to clipboard
Dec 2, 2020
Merged

Enable IDE0075: SimplifyConditionalExpression#14078
iSazonov merged 5 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:IDE0075xtqqczze/PowerShell-PowerShell:IDE0075Copy head branch name to clipboard

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

@ghost ghost assigned iSazonov Nov 13, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 16, 2020
@ghost ghost added the Stale label Dec 1, 2020
@ghost

ghost commented Dec 1, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Dec 1, 2020
@xtqqczze xtqqczze marked this pull request as ready for review December 1, 2020 10:29
Comment thread src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs Outdated
Comment thread src/System.Management.Automation/engine/hostifaces/PowerShell.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/client/ClientMethodExecutor.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/client/Job.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/server/ServerRemoteHost.cs Outdated
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 1, 2020
xtqqczze and others added 2 commits December 1, 2020 15:29
Remove unnecessary parenthesis.

Co-authored-by: Ilya <darpa@yandex.ru>
Comment thread src/System.Management.Automation/engine/GetCommandCommand.cs
@xtqqczze

xtqqczze commented Dec 1, 2020

Copy link
Copy Markdown
Contributor Author

@iSazonov Ae you happy to merge as-is, or do you want more changes to remove redundant parenthesis?

@iSazonov iSazonov merged commit 18717c5 into PowerShell:master Dec 2, 2020
@xtqqczze xtqqczze deleted the IDE0075 branch December 2, 2020 10:28
@ghost

ghost commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.