Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix IDE0044: MakeFieldReadonly part 11#13966

Merged
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:IDE0044-p11xtqqczze/PowerShell-PowerShell:IDE0044-p11Copy head branch name to clipboard
Nov 7, 2020
Merged

Fix IDE0044: MakeFieldReadonly part 11#13966
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:IDE0044-p11xtqqczze/PowerShell-PowerShell:IDE0044-p11Copy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044

Split from #13880 to ease review.

src\System.Management.Automation\engine\remoting\

src\System.Management.Automation\engine\remoting\
@ghost ghost assigned anmenaga Nov 2, 2020
@iSazonov iSazonov requested a review from PaulHigin November 3, 2020 06:08
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 3, 2020
Comment thread src/System.Management.Automation/engine/remoting/client/Job.cs
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 3, 2020
@iSazonov

iSazonov commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

@xtqqczze Please look @PaulHigin's comments.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 6, 2020
@iSazonov

iSazonov commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator

@PaulHigin Please update your review.

@PaulHigin

Copy link
Copy Markdown
Contributor

@iSazonov I'll approve once all requested changes are made.

@iSazonov

iSazonov commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator

@xtqqczze Please look new comments.

@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Nov 7, 2020
@iSazonov iSazonov merged commit d128fbc into PowerShell:master Nov 7, 2020
@xtqqczze xtqqczze deleted the IDE0044-p11 branch November 7, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.