Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix typo in MapSecurityZone#13921

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:fix-typo-mapsecurityzoneiSazonov/PowerShell:fix-typo-mapsecurityzoneCopy head branch name to clipboard
Nov 3, 2020
Merged

Fix typo in MapSecurityZone#13921
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:fix-typo-mapsecurityzoneiSazonov/PowerShell:fix-typo-mapsecurityzoneCopy head branch name to clipboard

Conversation

@iSazonov

@iSazonov iSazonov commented Oct 29, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

Fix typo which comes from #11884 - "Internet" and "Intranet" names are too similar.
Discovered by @mklement0 #13869 (comment)

PR Context

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 29, 2020
@iSazonov iSazonov requested a review from SteveL-MSFT October 29, 2020 03:50
@iSazonov iSazonov self-assigned this Oct 29, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator Author

I could add xUnit tests for the code (in follow PR).

@mklement0

Copy link
Copy Markdown
Contributor

I think test are definitely called for, given the potentially grave consequences of such a logic error.

@DEberhardt DEberhardt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Logic fix

@TravisEz13 TravisEz13 assigned daxian-dbw and unassigned iSazonov Oct 30, 2020
@daxian-dbw daxian-dbw added CL-Engine Indicates that a PR should be marked as an engine change in the Change Log and removed CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log labels Nov 3, 2020
@daxian-dbw daxian-dbw merged commit 53e8199 into PowerShell:master Nov 3, 2020
@iSazonov iSazonov deleted the fix-typo-mapsecurityzone branch November 3, 2020 03:43
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 3, 2020
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Nov 10, 2020
@ghost

ghost commented Nov 11, 2020

Copy link
Copy Markdown

🎉v7.1.0 has been released which incorporates this pull request.:tada:

Handy links:

@prem874 prem874 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.1.x-Done Backport to 7.1.x completed CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.