Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Enable IDE0048: AddRequiredParentheses#13896

Merged
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:IDE0048xtqqczze/PowerShell-PowerShell:IDE0048Copy head branch name to clipboard
Oct 29, 2020
Merged

Enable IDE0048: AddRequiredParentheses#13896
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:IDE0048xtqqczze/PowerShell-PowerShell:IDE0048Copy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 26, 2020

Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze marked this pull request as ready for review October 27, 2020 15:06
@iSazonov

iSazonov commented Oct 29, 2020

Copy link
Copy Markdown
Collaborator

Default is always_for_clarity for arithmetic, relational, and other binary operators.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 29, 2020
@iSazonov iSazonov merged commit 83a3f53 into PowerShell:master Oct 29, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Oct 29, 2020
@xtqqczze xtqqczze deleted the IDE0048 branch October 29, 2020 14:25
@xtqqczze xtqqczze mentioned this pull request Oct 29, 2020
Closed
@xtqqczze

xtqqczze commented Oct 29, 2020

Copy link
Copy Markdown
Contributor Author

This PR did not fix all IDE0048 violations, see #13936. Since the severity was set to warning, the build should not have completed!

@iSazonov

iSazonov commented Oct 30, 2020

Copy link
Copy Markdown
Collaborator

Is it a bug in the Roslyn analyzer?

@xtqqczze xtqqczze restored the IDE0048 branch October 30, 2020 14:07
@xtqqczze xtqqczze deleted the IDE0048 branch November 2, 2020 03:51
@xtqqczze

xtqqczze commented Nov 2, 2020

Copy link
Copy Markdown
Contributor Author

Is it a bug in the Roslyn analyzer?

No EnforceCodeStyleInBuild was not enabled.

@ghost

ghost commented Nov 17, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @adityapatwardhan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.