Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enable IDE0054: Use compound assignment#13546

Merged
iSazonov merged 5 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:IDE0054xtqqczze/PowerShell-PowerShell:IDE0054Copy head branch name to clipboard
Nov 5, 2020
Merged

Enable IDE0054: Use compound assignment#13546
iSazonov merged 5 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:IDE0054xtqqczze/PowerShell-PowerShell:IDE0054Copy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 30, 2020

Copy link
Copy Markdown
Contributor

PR Summary

Use compound assignment:

diff = diff * r -> diff *= r

https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0054-ide0074

PR Context

See also: #13396

PR Checklist

@ghost ghost assigned TravisEz13 Aug 30, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 2, 2020
@ghost ghost added the Stale label Sep 17, 2020
@ghost

ghost commented Sep 17, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Sep 28, 2020
@iSazonov iSazonov reopened this Oct 16, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator

@xtqqczze Is it still Draft?

@ghost ghost removed the Stale label Oct 16, 2020
@xtqqczze xtqqczze changed the title WIP: Fix IDE0054 Fix IDE0054: Use compound assignment Oct 22, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 22, 2020
@xtqqczze

Copy link
Copy Markdown
Contributor Author

rebased to restart tests

@xtqqczze xtqqczze marked this pull request as ready for review October 22, 2020 14:53
@xtqqczze xtqqczze marked this pull request as draft October 22, 2020 22:39
@xtqqczze xtqqczze marked this pull request as ready for review October 22, 2020 22:39
@xtqqczze xtqqczze changed the title Fix IDE0054: Use compound assignment Enable IDE0054: Use compound assignment Oct 26, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 26, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 3, 2020
@ghost

ghost commented Nov 3, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov self-assigned this Nov 5, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@iSazonov iSazonov merged commit 3ba6106 into PowerShell:master Nov 5, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 5, 2020
@xtqqczze xtqqczze deleted the IDE0054 branch November 5, 2020 16:22
@ghost

ghost commented Nov 17, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.