Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use read-only auto-implemented properties#13507

Merged
iSazonov merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:RCS1170xtqqczze/PowerShell-PowerShell:RCS1170Copy head branch name to clipboard
Sep 2, 2020
Merged

Use read-only auto-implemented properties#13507
iSazonov merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:RCS1170xtqqczze/PowerShell-PowerShell:RCS1170Copy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 23, 2020

Copy link
Copy Markdown
Contributor

PR Summary

Fix RCS1170: Use read-only auto-implemented property

This PR made changes to ComInterop, so a corresponding PR was merged in dotnet/runtime#44677.

PR Context

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1170.md

PR Checklist

@ghost ghost assigned iSazonov Aug 23, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 27, 2020
@xtqqczze xtqqczze marked this pull request as ready for review August 28, 2020 20:23
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 28, 2020
@xtqqczze xtqqczze mentioned this pull request Aug 28, 2020
8 tasks
@iSazonov iSazonov added CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers labels Aug 29, 2020
@daxian-dbw

Copy link
Copy Markdown
Member

@PowerShell/powershell-maintainers reviewed this PR and agreed to accept this clean-up change with the following reason(s):

Even though the rule RCS1170 is informational level only, the chance of regression and confliction is low.

@daxian-dbw daxian-dbw removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 1, 2020
@iSazonov iSazonov merged commit 8598903 into PowerShell:master Sep 2, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.7 milestone Sep 2, 2020
@xtqqczze xtqqczze deleted the RCS1170 branch September 2, 2020 16:21
@ghost

ghost commented Sep 8, 2020

Copy link
Copy Markdown

🎉v7.1.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze

Copy link
Copy Markdown
Contributor Author

This PR made changes to ComInterop, so a corresponding PR was merged in dotnet/runtime#44677.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.