Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove ComEnumerator as COM objects using IEnumerator is now supported in .NET 5#13259

Merged
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:comdaxian-dbw/PowerShell:comCopy head branch name to clipboard
Jul 29, 2020
Merged

Remove ComEnumerator as COM objects using IEnumerator is now supported in .NET 5#13259
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:comdaxian-dbw/PowerShell:comCopy head branch name to clipboard

Conversation

@daxian-dbw

Copy link
Copy Markdown
Member

PR Summary

Fix #12881

.NET 5 now support COM objects using IEnumerator (IEnumVARIANT) (the fix is in .NET 5 preview 7), so in our code, the ComEnumerator, that handles IEnumVARIANT can be removed.

The ComEnumerator was introduced in #4553 3 years ago to make PowerShell able to enumerate COM object.
The support for COM objects that use IEnumerable was back in .NET 3.1, so #11795 reverted some of our changes.
This is a follow-up PR, to remove the remaining ComEnumerator code since now .NET 5 finally supports COM objects that use IEnumerator.

No new test is needed.

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 24, 2020
@daxian-dbw

Copy link
Copy Markdown
Member Author

@iSazonov I think it's ready to merge :) thanks!

@PaulHigin PaulHigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov merged commit 74ddc3e into PowerShell:master Jul 29, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.7 milestone Jul 29, 2020
@daxian-dbw daxian-dbw deleted the com branch July 29, 2020 17:53
@TravisEz13 TravisEz13 modified the milestones: 7.1.0-preview.7, 7.1.0-preview.6 Aug 5, 2020
@ghost

ghost commented Aug 17, 2020

Copy link
Copy Markdown

🎉v7.1.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the 'ComEnumerator' code as the support is now in .NET 5

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.