Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Check for ico file in daily install script#13078

Closed
rjmholt wants to merge 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
rjmholt:fix-daily-installrjmholt/PowerShell:fix-daily-installCopy head branch name to clipboard
Closed

Check for ico file in daily install script#13078
rjmholt wants to merge 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
rjmholt:fix-daily-installrjmholt/PowerShell:fix-daily-installCopy head branch name to clipboard

Conversation

@rjmholt

@rjmholt rjmholt commented Jul 1, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #13077.

We now only try to set the icon for pwsh.exe when the ico file is in the payload.

PR Context

PR Checklist

@iSazonov

iSazonov commented Jul 2, 2020

Copy link
Copy Markdown
Collaborator

Dup #13060?

@rjmholt

rjmholt commented Jul 2, 2020

Copy link
Copy Markdown
Collaborator Author

Closing in favour of #13060

@rjmholt rjmholt closed this Jul 2, 2020
@rjmholt rjmholt deleted the fix-daily-install branch July 30, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daily install script icon rcedit error causes script failure

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.