Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Code redundancy fixes#12916

Merged
iSazonov merged 7 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:RCS-Redundancy-fixesxtqqczze/PowerShell-PowerShell:RCS-Redundancy-fixesCopy head branch name to clipboard
Jun 11, 2020
Merged

Code redundancy fixes#12916
iSazonov merged 7 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:RCS-Redundancy-fixesxtqqczze/PowerShell-PowerShell:RCS-Redundancy-fixesCopy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

PR Summary

Using selected Roslynator "Redundancy" fixes.

PR Context

PR Checklist

@ghost ghost assigned iSazonov Jun 8, 2020
@xtqqczze xtqqczze force-pushed the RCS-Redundancy-fixes branch from 48ed879 to 463f38d Compare June 8, 2020 02:25
@xtqqczze xtqqczze marked this pull request as ready for review June 8, 2020 02:55
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 8, 2020
@xtqqczze xtqqczze force-pushed the RCS-Redundancy-fixes branch from 463f38d to 651eea0 Compare June 8, 2020 09:40
@xtqqczze

xtqqczze commented Jun 8, 2020

Copy link
Copy Markdown
Contributor Author

rebased to remove RCS1032

@iSazonov iSazonov added the AutoMerge informs the bot to automerge the PR label Jun 9, 2020
@ghost

ghost commented Jun 9, 2020

Copy link
Copy Markdown

Hello @iSazonov!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@iSazonov iSazonov added this to the 7.1.0-preview.4 milestone Jun 9, 2020
@xtqqczze

Copy link
Copy Markdown
Contributor Author

@iSazonov It seems the failed Codacy check is preventing automerge.

@iSazonov iSazonov removed the AutoMerge informs the bot to automerge the PR label Jun 11, 2020
@iSazonov iSazonov merged commit 0d5d017 into PowerShell:master Jun 11, 2020
@xtqqczze xtqqczze deleted the RCS-Redundancy-fixes branch June 12, 2020 00:52
@ghost

ghost commented Jun 25, 2020

Copy link
Copy Markdown

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.