cleanup: Use single expectation for each It block#12714
Closed
xtqqczze wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:pester-compare-arrayxtqqczze/PowerShell-PowerShell:pester-compare-arrayCopy head branch name to clipboard
Closed
cleanup: Use single expectation for each It block#12714xtqqczze wants to merge 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom xtqqczze:pester-compare-arrayxtqqczze/PowerShell-PowerShell:pester-compare-arrayCopy head branch name to clipboard
xtqqczze wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:pester-compare-arrayxtqqczze/PowerShell-PowerShell:pester-compare-arrayCopy head branch name to clipboard
Conversation
vexx32
reviewed
May 18, 2020
iSazonov
requested changes
May 19, 2020
iSazonov
left a comment
Collaborator
There was a problem hiding this comment.
I can not accept these changes and suggest to close the PR.
iSazonov
reviewed
May 19, 2020
5f6ef00 to
8d6edcb
Compare
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Collaborator
|
The PR looks very dangerous. I believe this does not add benefits. I close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
Convention is to assert a single expectation for each
Itblock. [1]PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.