Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Encoding Parameter for Tee-Object#12135

Merged
iSazonov merged 6 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
Peter-Schneider:TeeObjectEncodingParameterCopy head branch name to clipboard
Jul 22, 2021
Merged

Encoding Parameter for Tee-Object#12135
iSazonov merged 6 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
Peter-Schneider:TeeObjectEncodingParameterCopy head branch name to clipboard

Conversation

@Peter-Schneider

@Peter-Schneider Peter-Schneider commented Mar 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Adds an Encoding parameter to the Tee-Object cmdlet (See issue #11104)

PR Context

PR Checklist

@ghost ghost assigned iSazonov Mar 16, 2020
vexx32
vexx32 suggested changes Mar 16, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Outdated
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Outdated
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Outdated
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
@vexx32

vexx32 commented Mar 16, 2020

Copy link
Copy Markdown
Collaborator

Ha, you beat me to it. 😁

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
christian7877
christian7877 suggested changes Mar 16, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Outdated
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Outdated
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 16, 2020
@Peter-Schneider

Peter-Schneider commented Mar 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@vexx32 Thank you anyway.. ;-)

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 17, 2020
@iSazonov

iSazonov commented Mar 17, 2020

Copy link
Copy Markdown
Collaborator

@Peter-Schneider Please add tests.

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 17, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Mar 17, 2020
@iSazonov iSazonov added the Documentation Needed in this repo Documentation is needed in this repo label Mar 17, 2020
iSazonov
iSazonov reviewed Mar 18, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
iSazonov
iSazonov reviewed Mar 18, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
iSazonov
iSazonov reviewed Mar 18, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
iSazonov
iSazonov reviewed Mar 19, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs Outdated
@iSazonov

iSazonov commented Mar 20, 2020

Copy link
Copy Markdown
Collaborator

@Peter-Schneider Please open new issue in PowerShell-Docs repo for the new parameter and add reference in the PR description.

@Peter-Schneider Peter-Schneider mentioned this pull request Mar 20, 2020
Closed
11 tasks
@iSazonov

iSazonov commented Mar 20, 2020

Copy link
Copy Markdown
Collaborator

@SteveL-MSFT @TravisEz13 Could you please look CI failures? It seems it is not the PR related.

@TravisEz13

TravisEz13 commented Mar 20, 2020

Copy link
Copy Markdown
Member

@iSazonov The windows failure definitely seem related to this branch. Perhaps a rebase is needed.

@iSazonov

iSazonov commented Mar 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@Peter-Schneider Please rebase. You will be switched to new .Net version - 5.0 Preview1, so you should install it.

iSazonov
iSazonov reviewed Mar 21, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
iSazonov
iSazonov reviewed Mar 21, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
Peter-Schneider and others added 2 commits March 21, 2020 17:14
@Peter-Schneider
Delte testfile in BeforeEach Pester block
b08faa4
@Peter-Schneider @iSazonov
Fix CI
3af62f4 
Co-Authored-By: Ilya <darpa@yandex.ru>
iSazonov
iSazonov reviewed Mar 22, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Tee-Object.Tests.ps1 Outdated
@TravisEz13 TravisEz13 removed the Review - Needed The PR is being reviewed label Jun 2, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 10, 2020
@ghost

ghost commented Jun 10, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@iSazonov

iSazonov commented Jun 11, 2020

Copy link
Copy Markdown
Collaborator

@TravisEz13 @SteveL-MSFT Could you please review the PR.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 11, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 18, 2020
@ghost

ghost commented Jun 18, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan adityapatwardhan removed this from the 7.1.0-preview.4 milestone Jun 29, 2020
@iSazonov iSazonov closed this Jul 22, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 22, 2020
@iSazonov iSazonov reopened this Jul 22, 2020
@iSazonov

iSazonov commented Jul 22, 2020

Copy link
Copy Markdown
Collaborator

Reopen to update CIs.

@ghost ghost added the Review - Needed The PR is being reviewed label Jul 30, 2020
@ghost

ghost commented Jul 30, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov

iSazonov commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

@SteveL-MSFT Can we merge?

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 16, 2021
@ghost

ghost commented Jan 16, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@SteveL-MSFT

SteveL-MSFT commented Jul 21, 2021

Copy link
Copy Markdown
Member

@iSazonov I think this is good to go. thanks.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 21, 2021
@SteveL-MSFT SteveL-MSFT reopened this Jul 21, 2021
@iSazonov iSazonov merged commit de5dc63 into PowerShell:master Jul 22, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jul 22, 2021
@iSazonov

iSazonov commented Jul 22, 2021

Copy link
Copy Markdown
Collaborator

@Peter-Schneider Thanks for your contribution!

@Peter-Schneider

Peter-Schneider commented Jul 22, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for merging! 🥳

@ghost

ghost commented Aug 23, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

ghost commented Sep 28, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+2 more reviewers

@christian7877 christian7877 christian7877 requested changes

@vexx32 vexx32 vexx32 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.8

Development

Successfully merging this pull request may close these issues.

7 participants

@Peter-Schneider @vexx32 @iSazonov @TravisEz13 @SteveL-MSFT @christian7877 @adityapatwardhan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.