Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

vscode: Enable EditorConfig support in OmniSharp#11627

Merged
anmenaga merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:omnisharp-EditorConfig-supportxtqqczze/PowerShell-PowerShell:omnisharp-EditorConfig-supportCopy head branch name to clipboard
Jan 24, 2020
Merged

vscode: Enable EditorConfig support in OmniSharp#11627
anmenaga merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:omnisharp-EditorConfig-supportxtqqczze/PowerShell-PowerShell:omnisharp-EditorConfig-supportCopy head branch name to clipboard

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

PR Summary

Enable support for EditorConfig in OmniSharp.

PR Context

OmniSharp has this support since omnisharp-roslyn v1.33.0:

PR Checklist

Enable support for EditorConfig in OmniSharp. Since omnisharp-roslyn version 1.33.0, OmniSharp has had this support.

* https://github.com/OmniSharp/omnisharp-roslyn/blob/master/CHANGELOG.md#1330---2019-07-01
* PowerShell#7357
* OmniSharp/omnisharp-roslyn#1526
@ghost ghost assigned anmenaga Jan 19, 2020

@iSazonov iSazonov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I tried enableRoslynAnalyzers. It takes many time for analyzing and we need to adjust before enable.

@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jan 19, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Jan 19, 2020
@vexx32

vexx32 commented Jan 19, 2020

Copy link
Copy Markdown
Collaborator

@iSazonov I've used the enableRoslynAnalyzers setting as a good tool to work with when doing a cleanup / refactor of an individual file. It will probably be quite a while before we get all those analyzer recommendations into the codebase, but the majority of them do look like great suggestions to take on board.

@iSazonov

Copy link
Copy Markdown
Collaborator

My concern is that it takes a lot of computer resources. Perhaps we could enable subset of the analyzer to highlight our code conventions.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

@vexx32 I too am using enableRoslynAnalyzers, with additional PackageReference Roslynator.Analyzers added to a csproj of interest. I have submitted PR #11640 based on one of the analyzer recommendations, but it seems like a huge amount of work to fix all issues.

@iSazonov Currently Omnisharp queues all documents in the solution for code analysis, rather than running on demand, so this uses a lot of resources when developing in vscode.

@iSazonov

Copy link
Copy Markdown
Collaborator

@xtqqczze Can we configure the code analysis?

@anmenaga anmenaga merged commit ba639a6 into PowerShell:master Jan 24, 2020
@xtqqczze xtqqczze deleted the omnisharp-EditorConfig-support branch February 1, 2020 12:46
@ghost

ghost commented Mar 26, 2020

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.