Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Improvements in breakpoint APIs for remote scenarios#11312

Merged
adityapatwardhan merged 15 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
TylerLeonhardt:improve-breakpoint-apisTylerLeonhardt/PowerShell:improve-breakpoint-apisCopy head branch name to clipboard
Dec 13, 2019
Merged

Improvements in breakpoint APIs for remote scenarios#11312
adityapatwardhan merged 15 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
TylerLeonhardt:improve-breakpoint-apisTylerLeonhardt/PowerShell:improve-breakpoint-apisCopy head branch name to clipboard

Conversation

@TylerLeonhardt

@TylerLeonhardt TylerLeonhardt commented Dec 10, 2019

Copy link
Copy Markdown
Member

PR Summary

This addresses two things:

  • gives the ability to set a breakpoint remotely on a runspace even if it's busy
  • gives the ability to set a breakpoint on a specific runspace

This is only added to the API surface for the PowerShell extension. In theory the breakpoint cmdlets can take advantage of this in the future.

PR Context

This will light up a scenario in the PowerShell Editor Services so that when you click to add a breakpoint, that breakpoint will be applied even if the PowerShell Integrated Console is busy running the Debug-Runspace.

PR Checklist

@ghost ghost assigned anmenaga Dec 10, 2019
Comment thread src/System.Management.Automation/engine/debugger/debugger.cs
Comment thread src/System.Management.Automation/engine/debugger/debugger.cs
Comment thread src/System.Management.Automation/engine/debugger/debugger.cs
@TylerLeonhardt

Copy link
Copy Markdown
Member Author

The "hook in output" commit hooks up the ability to send output to the original client PowerShell without needing to invoke a pipeline on the server side.

@TylerLeonhardt TylerLeonhardt changed the title WIP: Improvements in breakpoint APIs for remote scenarios Improvements in breakpoint APIs for remote scenarios Dec 11, 2019
@TylerLeonhardt TylerLeonhardt marked this pull request as ready for review December 11, 2019 17:45
Comment thread src/System.Management.Automation/engine/debugger/debugger.cs Outdated
Comment thread src/System.Management.Automation/engine/debugger/debugger.cs Outdated
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 11, 2019
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 11, 2019
@adityapatwardhan adityapatwardhan added this to the rc.1-consider milestone Dec 11, 2019
@adityapatwardhan adityapatwardhan added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Dec 11, 2019
Comment thread src/System.Management.Automation/engine/debugger/debugger.cs
@TylerLeonhardt

Copy link
Copy Markdown
Member Author

@PoshChan please retry PowerShell-CI-static-analysis

@PoshChan

Copy link
Copy Markdown
Collaborator

@TylerLeonhardt, I do not understand the build target(s) PowerShell-CI-static-analysis; I only allow static, windows, macos, linux, all

@TylerLeonhardt

Copy link
Copy Markdown
Member Author

@PoshChan please retry static

@PoshChan

Copy link
Copy Markdown
Collaborator

@TylerLeonhardt, successfully started retry of PowerShell-CI-static-analysis

Comment thread src/System.Management.Automation/engine/debugger/debugger.cs
Comment thread src/System.Management.Automation/engine/debugger/debugger.cs
@TylerLeonhardt

Copy link
Copy Markdown
Member Author

@PoshChan please retry static

@TylerLeonhardt

Copy link
Copy Markdown
Member Author

@PoshChan please retry windows

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 12, 2019
Comment thread src/System.Management.Automation/engine/debugger/debugger.cs
Comment thread src/System.Management.Automation/resources/DebuggerStrings.resx Outdated

@PaulHigin PaulHigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan

Copy link
Copy Markdown
Member

@SteveL-MSFT - please update your review

Comment thread src/System.Management.Automation/engine/debugger/debugger.cs Outdated
Comment thread src/System.Management.Automation/engine/debugger/debugger.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/client/remoterunspace.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/client/remoterunspace.cs Outdated
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 12, 2019
@adityapatwardhan

Copy link
Copy Markdown
Member

@SteveL-MSFT - please re-review

@adityapatwardhan adityapatwardhan merged commit ca202da into PowerShell:master Dec 13, 2019
@TylerLeonhardt TylerLeonhardt deleted the improve-breakpoint-apis branch December 13, 2019 17:55
@ghost

ghost commented Dec 16, 2019

Copy link
Copy Markdown

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.