Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove the unused setting key ConsolePrompting and avoid unnecessary string creation when querying ExecutionPolicy setting#10985

Merged
iSazonov merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:configdaxian-dbw/PowerShell:configCopy head branch name to clipboard
Nov 6, 2019
Merged

Remove the unused setting key ConsolePrompting and avoid unnecessary string creation when querying ExecutionPolicy setting#10985
iSazonov merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:configdaxian-dbw/PowerShell:configCopy head branch name to clipboard

Conversation

@daxian-dbw

@daxian-dbw daxian-dbw commented Nov 4, 2019

Copy link
Copy Markdown
Member

PR Summary

Remove the unused setting key ConsolePrompting and avoid unnecessary string creation when querying ExecutionPolicy setting
The ConsolePrompting setting is not used anywhere because the functionality depended on it was not supporting and had been removed in #4995

The changes to GetExecutionPolicy, RemoveExecutionPolicy and SetExecutionPolicy avoid unnecessary string allocation for the default PowerShell shell Id.

PR Context

PR Checklist

@daxian-dbw daxian-dbw requested a review from iSazonov November 4, 2019 20:36
@daxian-dbw daxian-dbw added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 4, 2019
Comment thread src/System.Management.Automation/engine/PSConfiguration.cs Outdated
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Nov 6, 2019
@iSazonov iSazonov merged commit 6aa3188 into PowerShell:master Nov 6, 2019
@daxian-dbw daxian-dbw deleted the config branch November 6, 2019 07:24
@ghost

ghost commented Nov 21, 2019

Copy link
Copy Markdown

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.