Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Renamed wrongly named file#10659

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
kilasuit:invokeExpressionCmdletkilasuit/PowerShell:invokeExpressionCmdletCopy head branch name to clipboard
Oct 7, 2019
Merged

Renamed wrongly named file#10659
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
kilasuit:invokeExpressionCmdletkilasuit/PowerShell:invokeExpressionCmdletCopy head branch name to clipboard

Conversation

@kilasuit

@kilasuit kilasuit commented Oct 1, 2019

Copy link
Copy Markdown
Collaborator

PR Summary

This PR fixes the incorrectly named InvokeCommandCmdlet.cs which contained Invoke-Expression definition.

PR Context

fix #9807
Make sure file name matches intended content

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 1, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Oct 1, 2019

@PaulHigin PaulHigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not very consistent in our file naming, but I believe the file name should be 'InvokeExpressionCommand.cs'.

@adityapatwardhan Will renaming a source file cause any build/packaging problems?

@daxian-dbw

Copy link
Copy Markdown
Member

I agree with @PaulHigin

@kilasuit kilasuit force-pushed the invokeExpressionCmdlet branch from 6a15abb to 4433029 Compare October 1, 2019 18:00
@kilasuit

kilasuit commented Oct 1, 2019

Copy link
Copy Markdown
Collaborator Author

@PaulHigin - I've locally tested that change will still build pwsh & the command runs fine & also renamed the file to InvokeExpressionCommand.cs based on your comment

@PaulHigin PaulHigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT

Copy link
Copy Markdown
Member

@PoshChan please retry macos

@PoshChan

PoshChan commented Oct 2, 2019

Copy link
Copy Markdown
Collaborator

@SteveL-MSFT, successfully started retry of PowerShell-CI-macOS

@SteveL-MSFT

Copy link
Copy Markdown
Member

@PaulHigin renaming this file shouldn't cause any issues as build csproj implicitly includes cs files rather than explicitly. packaging only cares about the binary output and not source files.

@daxian-dbw daxian-dbw changed the title renamed wrongly named file - fixes #9807 Renamed wrongly named file Oct 7, 2019
@daxian-dbw daxian-dbw merged commit c08c7e4 into PowerShell:master Oct 7, 2019
@kilasuit kilasuit deleted the invokeExpressionCmdlet branch October 7, 2019 20:50
@ghost

ghost commented Oct 23, 2019

Copy link
Copy Markdown

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvokeCommandCmdlet.cs is actually for invoke-expression cmdlet

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.