Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

CodeFactor PR check flags up problems on ontouched and unrelated lines/methods #6941

Copy link
Copy link
@bergmeister

Description

@bergmeister
Issue body actions

As per title, the CodeFactor check makes most PRs red because it flags up issues that are unrelated to the PR.
This is due to the files containing a lot of other code. Neither do I want to change unrelated code as part of the PR nor seeing the PR checks as red, we should not have a '50 shades of red' build.
The team should clean up the warnings first or suppress some of the warnings since so far most of them are purely stylistic.
.Net Core has the Microsoft.CodeAnalysis.FxCopAnalyzers NuGet package, which is a subset of the CA warnings that most people are familiar with from the full .Net framework, I found those warnings more useful rather than having a linter check, since linters are more useful when being used in VS Code extensions

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aResolution-AnsweredThe question is answered.The question is answered.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.