Currently, the systemTranscript field is updated by StopAllTranscribing and GetSystemTranscriptOption; however, GetSystemTranscriptOption updates the field within a lock but returns the field value outside the lock. From the code, the implication is the value just set in the field should also be returned but a race can occur with StopAllTranscribing that can result in a null reference being returned.

Steps to reproduce

Code review

Expected behavior

Either a comment clarify the intent or function should return the updated field value.

Actual behavior

Not deterministic

Environment data

PSVersion 6.1.0-preview.535
PSEdition Core
GitCommitId v6.1.0-preview.535
OS Microsoft Windows 10.0.17070
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0