Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

IFeedbackProvider can't work against native commands on non-zero exit code #18852

Copy link
Copy link
@SteveL-MSFT

Description

@SteveL-MSFT
Issue body actions

Summary of the new feature / enhancement

The current design of IFeedbackProvider only works against an ErrorRecord. Unless $PSNativeCommandUseErrorActionPreference is $true, no ErrorRecord is created if a native command exists with a non-zero exit code. For example, I can't build a feedback provider for the git command.

Proposed technical implementation details (optional)

Perhaps FeedbackProviders should be registered with a Kind specifying when it should be enacted? I don't know if there will be other cases other than ErrorRecord and non-zero exit code.

cc @daxian-dbw

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

Issue-Enhancementthe issue is more of a feature request than a bugthe issue is more of a feature request than a bugKeepOpenThe bot will ignore these and not auto-closeThe bot will ignore these and not auto-closeWG-Enginecore PowerShell engine, interpreter, and runtimecore PowerShell engine, interpreter, and runtime

Type

No type
No fields configured for issues without a type.

Projects

Status
Potentially for 7.4 GA
Show more project fields

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.