Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Further changes/improvement needed to module path calculation #1744

Copy link
Copy link
@daxian-dbw

Description

@daxian-dbw
Issue body actions

While working on the sxs module path, I found some method names are intuitive, for example, GetDscModulePath() actually returns the Program Files shared module path, GetSystemWideModulePath() actually returns the pshome module path. Those method need to be renamed.

  • Refactor method names related to module path calculation
  • The code that detects if a module path is PSHome module path derived from parent process needs to be smarter, not only check powershell file in the parent folder, but maybe check powershell.deps.json file as well, and also the short folder name of the path should be Modules. The current detection logic casued a test to fail in Travis CI, see Fix the test that fails in Travis CI build #1792
  • Add more SxS module path tests
  • Think about the name inbox of Platform.IsInbox property. Do we need a better name? Platform.IsInbox is an internal property, and it's well commented to clarify its meaning. We will keep this name unless there is a big concern about it.
Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

Resolution-FixedThe issue is fixed.The issue is fixed.WG-Enginecore PowerShell engine, interpreter, and runtimecore PowerShell engine, interpreter, and runtime

Type

No type
No fields configured for issues without a type.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.