Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Handle buffer changes made by a handler of the OnIdle event#4442

Merged
daxian-dbw merged 3 commits into
PowerShell:masterPowerShell/PSReadLine:masterfrom
daxian-dbw:insertdaxian-dbw/PSReadLine:insertCopy head branch name to clipboard
Feb 4, 2025
Merged

Handle buffer changes made by a handler of the OnIdle event#4442
daxian-dbw merged 3 commits into
PowerShell:masterPowerShell/PSReadLine:masterfrom
daxian-dbw:insertdaxian-dbw/PSReadLine:insertCopy head branch name to clipboard

Conversation

@daxian-dbw

@daxian-dbw daxian-dbw commented Feb 4, 2025

Copy link
Copy Markdown
Member

PR Summary

Fix #3939

Handle buffer changes made by a handler of the OnIdle event.
We don't update the initial cursor top when buffer was changed by an event handler.

It requires interaction with PowerShell to test out this change, and thus I cannot add an automation test.

buffer

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newline Handling of [Microsoft.PowerShell.PSConsoleReadLine]::Insert broken in Windows

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.