Fix conditions for ESRP templates#7
Merged
adityapatwardhan merged 8 commits intoOct 29, 2020
PowerShell:masterPowerShell/Compliance:masterfrom
adityapatwardhan:FixTemplateConditionadityapatwardhan/Compliance-1:FixTemplateConditionCopy head branch name to clipboard
Merged
Fix conditions for ESRP templates#7adityapatwardhan merged 8 commits intoPowerShell:masterPowerShell/Compliance:masterfrom adityapatwardhan:FixTemplateConditionadityapatwardhan/Compliance-1:FixTemplateConditionCopy head branch name to clipboard
adityapatwardhan merged 8 commits into
PowerShell:masterPowerShell/Compliance:masterfrom
adityapatwardhan:FixTemplateConditionadityapatwardhan/Compliance-1:FixTemplateConditionCopy head branch name to clipboard
Conversation
TravisEz13
approved these changes
Oct 27, 2020
Member
Author
|
More changes are required I will make them in this PR too. |
TravisEz13
approved these changes
Oct 29, 2020
TravisEz13
reviewed
Oct 29, 2020
| Write-Verbose -Verbose "pattern = '${{ parameters.pattern }}'" | ||
| displayName: Log parameters | ||
|
|
||
| - ${{ if eq(parameters.certificateId , 'CP-230012') }}: |
Member
There was a problem hiding this comment.
This cert should also use authenticode 'CP-231522'
Member
Author
There was a problem hiding this comment.
having them in a since if did not work for some reason.
TravisEz13
approved these changes
Oct 29, 2020
| operationSetCode = "NuGetSign" | ||
| toolName = "sign" | ||
| toolVersion = "1.0" | ||
| }, |
Member
Author
There was a problem hiding this comment.
could not get nuget verify to work, i will solve this later
TravisEz13
approved these changes
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix condition expression.