This repository was archived by the owner on Jan 30, 2026. It is now read-only.
Properly escape tool description to avoid malformed 'Markup' object#408
Merged
Merged
Properly escape tool description to avoid malformed 'Markup' object#408
Conversation
StevenBucher98
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Tool description may contain characters like
"[]", which will result in malformedMarkupobject because the square brackets characters have special meaning in markup language.The
set_config_valuetool from the MCP serverdesktop-commanderis an example of this bug -- it has"empty array ([])"in its description.The fix is to escape tool description to avoid malformed 'Markup' object.