Update import/export example logic#78
Open
dmiller-polysync wants to merge 1 commit into
masterPolySync/polysync-core-cpp-examples:masterfrom
maint/import-export-logicPolySync/polysync-core-cpp-examples:maint/import-export-logicCopy head branch name to clipboard
Open
Update import/export example logic#78dmiller-polysync wants to merge 1 commit intomasterPolySync/polysync-core-cpp-examples:masterfrom maint/import-export-logicPolySync/polysync-core-cpp-examples:maint/import-export-logicCopy head branch name to clipboard
dmiller-polysync wants to merge 1 commit into
masterPolySync/polysync-core-cpp-examples:masterfrom
maint/import-export-logicPolySync/polysync-core-cpp-examples:maint/import-export-logicCopy head branch name to clipboard
Conversation
Prior to this commit, LogSessionImport and LogSessionExport examples were reporting errors. This exposed an existing bug in polysync-core-cpp-api. This commit adds some improvements to the logic, including resource management for the _importer and _exporter member variables. Following the bugfix (CORE-653) merge, this commit will enable proper functionality for LogSessionImport and LogSessionExport examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, LogSessionImport and LogSessionExport examples were reporting errors.
This exposed an existing bug in polysync-core-cpp-api. This commit adds some improvements
to the logic, including resource management for the _importer and _exporter member variables.
Following the bugfix (CORE-653) merge, this commit will enable proper functionality for
LogSessionImport and LogSessionExport examples.