Expose TimeTrace::record(timestamp, ...) in the c wrapper. - #16
#16Open
yilongli wants to merge 1 commit into
Open
Expose TimeTrace::record(timestamp, ...) in the c wrapper.#16yilongli wants to merge 1 commit into
yilongli wants to merge 1 commit into
Conversation
yilongli
force-pushed
the
master
branch
3 times, most recently
from
November 17, 2018 04:12
b7804da to
b6bce4a
Compare
hq6
reviewed
Apr 16, 2019
hq6
left a comment
Member
There was a problem hiding this comment.
Yilong, please tell me in person if you make a Pull Request and I haven't responded for months. I totally just saw this because I don't seem to get email notifications on PerfUtils PR's.
| * uint32_t arg0, uint32_t arg1, uint32_t arg2, | ||
| * uint32_t arg3); | ||
| */ | ||
| void timetrace_record_ts(); |
Member
There was a problem hiding this comment.
Why does the comment in the CC file say that caller always needs to pass arg0-3 when this header clearly allows fewer arguments to be passed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15