Re-enable LeakSanitizer runs - #24765
#24765Open
sevan wants to merge 1 commit into
Perl:bleadPerl/perl5:bleadfrom
sevan:enable-leaksanitzer-runs-againsevan/perl5:enable-leaksanitzer-runs-againCopy head branch name to clipboard
Open
Re-enable LeakSanitizer runs#24765sevan wants to merge 1 commit intoPerl:bleadPerl/perl5:bleadfrom sevan:enable-leaksanitzer-runs-againsevan/perl5:enable-leaksanitzer-runs-againCopy head branch name to clipboard
sevan wants to merge 1 commit into
Perl:bleadPerl/perl5:bleadfrom
sevan:enable-leaksanitzer-runs-againsevan/perl5:enable-leaksanitzer-runs-againCopy head branch name to clipboard
Conversation
It's been almost 6 years since the feature was disabled due to instability running GDBM tests in commit 229e23b. The original intent in the commit which introduced the ASAN CI job was described in commit 4e4a36d "Whilst this *will* detect various dangerous mistakes involving bad memory accesses, it's far more likely to spot if changes create memory leaks." I think it is time to revisit to see after many tooling releases if LeakSanitizer is choking. If so, perhaps it would be better to remove GDBM install as part of this job until whatever triggers failures can be identified and fixed rather than limiting ASAN features in an ASAN CI job.
Contributor
Author
|
In the logs from the CI run here on Ubuntu 24.04, I see |
Contributor
Author
|
Same error is observed on Ubuntu 26.04 in the logs from PR #24767 |
Contributor
Author
|
The logs from the run on 26.04 shed a little more light. |
Contributor
Author
|
In PR #24767, I skipped installing libgdbm and libdb, and the LeakSanitizer error is still there. Seems like it's always when it comes to running the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been almost 6 years since the feature was disabled due to instability running GDBM tests in commit 229e23b. The original intent in the commit which introduced the ASAN CI job was described in commit 4e4a36d "Whilst this will detect various dangerous mistakes involving bad memory accesses, it's far more likely to spot if changes create memory leaks." I think it is time to revisit to see after many tooling releases if LeakSanitizer is choking. If so, perhaps it would be better to remove GDBM install as part of this job until whatever triggers failures can be identified and fixed rather than limiting ASAN features in an ASAN CI job.