This repository was archived by the owner on Mar 24, 2021. It is now read-only.
Socket reconnection on retries of JoinGroup, SyncGroup, LeaveGroup - #939
#939Open
saich wants to merge 3 commits into
Parsely:masterParsely/pykafka:masterfrom
Instamojo:bugfix/reconnect-socketsInstamojo/pykafka:bugfix/reconnect-socketsCopy head branch name to clipboard
Open
Socket reconnection on retries of JoinGroup, SyncGroup, LeaveGroup#939saich wants to merge 3 commits intoParsely:masterParsely/pykafka:masterfrom Instamojo:bugfix/reconnect-socketsInstamojo/pykafka:bugfix/reconnect-socketsCopy head branch name to clipboard
saich wants to merge 3 commits into
Parsely:masterParsely/pykafka:masterfrom
Instamojo:bugfix/reconnect-socketsInstamojo/pykafka:bugfix/reconnect-socketsCopy head branch name to clipboard
Conversation
Sync with upstream master
`Broker._get_unique_req_handler` is responsible to identify which `BrokerConnection` & which `RequestHandler` objects will be used for `JoinGroup`, `SyncGroup`, `LeaveGroup` etc. This change will ensure that this method doesn't reuse a disconnected connection without attempting to reconnect.
Codecov Report
@@ Coverage Diff @@
## master #939 +/- ##
==========================================
+ Coverage 83.32% 83.41% +0.09%
==========================================
Files 36 36
Lines 3807 3811 +4
Branches 562 563 +1
==========================================
+ Hits 3172 3179 +7
+ Misses 489 486 -3
Partials 146 146
Continue to review full report at Codecov.
|
Contributor
|
Thanks for the contribution. I think your first alternate suggestion of putting this functionality in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, if
JoinGroupsees a socket disconnection, it will retry again without reconnecting the connection which results in subsequent retries all to fail.This change will ensure that we attempt to reconnect the connection if see a disconnected connection while selecting a unique
RequestHandlerto use for this request.Alternative approaches that can be considered:
RequestHandler.requestbefore callingself.shared.requests.putBrokerConnection.requestif required