This repository was archived by the owner on Mar 24, 2021. It is now read-only.
fix broken version comparison used during ssl tests - #682
#682Open
emmettbutler wants to merge 5 commits into
masterParsely/pykafka:masterfrom
bugfix/ssl_test_version_checkParsely/pykafka:bugfix/ssl_test_version_checkCopy head branch name to clipboard
Open
fix broken version comparison used during ssl tests#682emmettbutler wants to merge 5 commits intomasterParsely/pykafka:masterfrom bugfix/ssl_test_version_checkParsely/pykafka:bugfix/ssl_test_version_checkCopy head branch name to clipboard
emmettbutler wants to merge 5 commits into
masterParsely/pykafka:masterfrom
bugfix/ssl_test_version_checkParsely/pykafka:bugfix/ssl_test_version_checkCopy head branch name to clipboard
Conversation
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
=========================================
Coverage ? 81.25%
=========================================
Files ? 25
Lines ? 3302
Branches ? 485
=========================================
Hits ? 2683
Misses ? 479
Partials ? 140
Continue to review full report at Codecov.
|
Contributor
Author
|
See the travis runs on this branch - ssl connections are currently failing with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a version comparison operation that caused ssl tests not to run under kafka 0.10.