airspeed_selector: fix inconsistent throttle units #26145
Draft
+14
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When battery scale significantly above 1 (battery far from full):
This is caused by mixing different throttle units (some with, some without battery scaling) in both of these places.
Solution
change everything to use high-level TECS throttle setpoints which do not include battery scaling. this is more approprate here, as these setpoints reflect closely what we want the vehicle to do, whereas the battery scaling (which enters in FixedwingRateControl) is more of an implementation detail in comparison.
TODO: