Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Dec 3, 2019. It is now read-only.

Favors Rails secrets for auth config#336

Merged
hpjaj merged 1 commit into
masterOperationCode/operationcode_backend:masterfrom
335-add-github-env-varsOperationCode/operationcode_backend:335-add-github-env-varsCopy head branch name to clipboard
Apr 30, 2018
Merged

Favors Rails secrets for auth config#336
hpjaj merged 1 commit into
masterOperationCode/operationcode_backend:masterfrom
335-add-github-env-varsOperationCode/operationcode_backend:335-add-github-env-varsCopy head branch name to clipboard

Conversation

@hpjaj
Copy link
Copy Markdown
Collaborator

@hpjaj hpjaj commented Apr 30, 2018

Description of changes

In order to utilize the aggregated GitHub stats feature, we need the GitHub authentication client_id and client_secret set.

Definition of Done

  • Add GitHub client_id and client_secret values to Kubernetes
  • Remove old GitHub secrets implementation

Issue Resolved

Fixes #335

@hpjaj hpjaj merged commit 3f28b4f into master Apr 30, 2018
@hpjaj hpjaj deleted the 335-add-github-env-vars branch April 30, 2018 02:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GitHub authentication secrets to Kubernetes

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.