Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Allow PHP 8.1#763

Open
Fredthelead wants to merge 10 commits into
Ocramius:2.15.xOcramius/ProxyManager:2.15.xfrom
Fredthelead:2.15.xFredthelead/ProxyManager:2.15.xCopy head branch name to clipboard
Open

Allow PHP 8.1#763
Fredthelead wants to merge 10 commits into
Ocramius:2.15.xOcramius/ProxyManager:2.15.xfrom
Fredthelead:2.15.xFredthelead/ProxyManager:2.15.xCopy head branch name to clipboard

Conversation

@Fredthelead

@Fredthelead Fredthelead commented Jul 11, 2022 •
edited
Loading

Copy link
Copy Markdown
  • Changed the PHP ~8.0.0 constraint to ~8.0
  • Ran composer update with composer 2.3.9 and PHP 8.0.21
  • Added PHP 8.1 to the github pipes
  • Updated psalm config and suppressed a false-positive

Fixes #721

@Ocramius Ocramius added this to the 2.15.0 milestone Jul 11, 2022
@Ocramius Ocramius self-assigned this Jul 11, 2022
Ocramius
Ocramius requested changes Jul 11, 2022
View reviewed changes
Comment thread psalm.xml Outdated
Comment thread psalm-baseline.xml Outdated
Ocramius
Ocramius reviewed Jul 11, 2022
View reviewed changes
Comment thread psalm.xml
@dfreudenberger

dfreudenberger commented Jul 22, 2022

Copy link
Copy Markdown

Anything that needs to be done in order to get this merged & released? Happy to help if something is missing.

@Ocramius

Ocramius commented Jul 22, 2022

Copy link
Copy Markdown
Owner

Release requires this work: https://github.com/Ocramius/ProxyManager/milestone/56

@Fredthelead

Fredthelead commented Jul 23, 2022

Copy link
Copy Markdown
Author

The problem with this PR is that the tests won't work with locked dependencies on both php 8.0 and 8.1. Not sure how to solve this without removing some tests.

@Ocramius

Ocramius commented Jul 23, 2022

Copy link
Copy Markdown
Owner

Supporting 8.0 and 8.1 at the same time might indeed be challenging.

I can suggest skipping some tests on 8.0, so we focus on releasing a version that works on both PHP 8.0 and 8.1, then drop 8.0 support in a new minor, which in turn removes all conditionals that disable some tests.

@Fredthelead
Fredthelead requested a review from Ocramius September 2, 2022 13:30
@jakublabno

jakublabno commented Oct 31, 2022

Copy link
Copy Markdown

Hi, any update on this?

@Ocramius

Ocramius commented Oct 31, 2022

Copy link
Copy Markdown
Owner

#738 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ocramius Ocramius Awaiting requested review from Ocramius

Assignees

@Ocramius Ocramius

Labels

enhancement

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

Add PHP 8.1 to CI pipeline

4 participants

@Fredthelead @dfreudenberger @Ocramius @jakublabno
Morty Proxy This is a proxified and sanitized view of the page, visit original site.