Optimize GetNodeMetadata - #1392
#1392Merged
AlinMoldovean merged 9 commits intoMay 5, 2021
Merged
Optimize GetNodeMetadata #1392
Conversation
mrsuciu
commented
May 4, 2021
Contributor
- Reduce number of callback hits on reading attributes
- Reduce number of reads to underlying data sources for unused attributes
- Use temporary cache to avoid multiple attribute read calls
- Optimize GetNodeMetadata calls for Read service calls
- Minor API change: INodeManager.GetNodeMetadata signature update
…olePermission attributes when specified; All service calls use only these attributes on validating AccessRestrictions and RolePermissions. Read and Browse services also cache the values for avoiding unecessary calls.
…OnlyValidationAttributes into permitionsOnly
… attribute value cache on Browse service
mregen
approved these changes
May 4, 2021
mregen
left a comment
Contributor
There was a problem hiding this comment.
beside this question on the signature, it looks ok
| BrowseResultMask resultMask, | ||
| Dictionary<NodeId, List<object>> uniqueNodesServiceAttributes = null, | ||
| bool permissionsOnly = false) | ||
| { |
Contributor
There was a problem hiding this comment.
is there really no issue changing the signature, e.g. with compiled code? In the past I see there was a INodeManager2 added with additional functions. same could be done here with a GetNodeMetaData2 with more parameters in a INodeManager3?
Contributor
There was a problem hiding this comment.
for compat it might also be etter to add the 5 parm function separately and not use the defaults. Maybe add it in INodeManager2 only?
Contributor
Author
There was a problem hiding this comment.
INodeManager2 now contains the 5 param function GetPermissionsMetadata which handles the optimizations and GetNodeMetadata is left as is.
…ptimized retrieval if necessary and reverted changes to INodeManager.GetNodeMetadata implementation; Fixed missing summary and typeo's
AlinMoldovean
approved these changes
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.