Add TargetFramework alias to the GetReferenceNearestTargetFrameworkTask - #7011
#7011Closed
nkolev92 wants to merge 4 commits into
devNuGet/NuGet.Client:devfrom
dev-nkolev92-addAliasToGetNearestTaskNuGet/NuGet.Client:dev-nkolev92-addAliasToGetNearestTaskCopy head branch name to clipboard
Closed
Add TargetFramework alias to the GetReferenceNearestTargetFrameworkTask#7011nkolev92 wants to merge 4 commits intodevNuGet/NuGet.Client:devfrom dev-nkolev92-addAliasToGetNearestTaskNuGet/NuGet.Client:dev-nkolev92-addAliasToGetNearestTaskCopy head branch name to clipboard
nkolev92 wants to merge 4 commits into
devNuGet/NuGet.Client:devfrom
dev-nkolev92-addAliasToGetNearestTaskNuGet/NuGet.Client:dev-nkolev92-addAliasToGetNearestTaskCopy head branch name to clipboard
Conversation
nkolev92
marked this pull request as ready for review
December 16, 2025 02:09
donnie-msft
approved these changes
Dec 17, 2025
| <PackageDownloadSupported>true</PackageDownloadSupported> | ||
| <!-- Mark that this targets file GetReferenceNearestTargetFrameworkTask task supports the TargetPlatformMoniker --> | ||
| <GetReferenceNearestTargetFrameworkTaskSupportsTargetPlatformParameter>true</GetReferenceNearestTargetFrameworkTaskSupportsTargetPlatformParameter> | ||
| <!-- Mark that this targets file GetReferenceNearestTargetFrameworkTask task supports the TargetFramework --> |
Contributor
There was a problem hiding this comment.
Link to the MSBuild PR or an Issue for reference?
Member
There was a problem hiding this comment.
zivkan
approved these changes
Dec 17, 2025
zivkan
force-pushed
the
dev-nkolev92-addAliasToGetNearestTask
branch
from
December 17, 2025 06:46
3ced076 to
a8cc064
Compare
JanProvaznik
pushed a commit
to dotnet/msbuild
that referenced
this pull request
Dec 19, 2025
Fixes # ### Context Design: NuGet/Home#12124 To allow duplicate frameworks in aliasing, the project reference protocol nearest framework selection needs to be updated to support matching by alias as well. Relevant part: https://github.com/NuGet/Home/blob/dev-nkolev92-tfmaliases/accepted/2025/Multiple-Equivalent-Framework-Support-TFM-As-Aliases.md#project-to-project-references NuGet/NuGet.Client#7011 NuGet.Client side adding the parameter. NuGet/NuGet.Client#6972 will add the full implementation at a later point. ### Changes Made - Pass CurrentProjectTargetFrameworkProperty if GetReferenceNearestTargetFrameworkTaskSupportsTargetFrameworKPropertyParameter is set. - If GetReferenceNearestTargetFrameworkTaskSupportsTargetFrameworKPropertyParameter is not set, but GetReferenceNearestTargetFrameworkTaskSupportsTargetPlatformParameter is set, call the old variation. - Otherwise calls the last variation. ### Testing - Manual testing. - I'd be happy to add tests if someone can point me in the right direction. ### Notes The idea here is to get ahead of things. Currently aliasing work can't be end to end tested because it requires an msbuild change. It makes it really hard to validate the NuGet changes are enough and good, but this is the only change needed on the msbuild side. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jeffkl
approved these changes
Dec 23, 2025
Contributor
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Progress: NuGet/Home#14536
Description
In order to allow for E2E integration of the aliasing feature to work (ie, to verify that we can run build on an aliased lock file), we need the project reference protocol inputs to be setup.
https://github.com/NuGet/Home/blob/dev-nkolev92-tfmaliases/accepted/2025/Multiple-Equivalent-Framework-Support-TFM-As-Aliases.md#project-to-project-references
This PR adds the parameter to TargetFramework, which will be consider at a later point. #6972 is already implemented, but it's not at the quality we need it to be just yet because of the lack of the ability to add E2E tests at this point.
MSBuild side in dotnet/msbuild#12932.
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.