Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Nullable annotate SPDX license data - #6965

#6965
Merged
zivkan merged 1 commit into
devNuGet/NuGet.Client:devfrom
dev-zivkan-spdx-nullableNuGet/NuGet.Client:dev-zivkan-spdx-nullableCopy head branch name to clipboard
Nov 23, 2025
Merged

Nullable annotate SPDX license data#6965
zivkan merged 1 commit into
devNuGet/NuGet.Client:devfrom
dev-zivkan-spdx-nullableNuGet/NuGet.Client:dev-zivkan-spdx-nullableCopy head branch name to clipboard

Conversation

@zivkan

@zivkan zivkan commented Nov 21, 2025

Copy link
Copy Markdown
Member

Bug

Fixes: spdx licence update pipeline

Description

In #6960 I made all code enable nullable checks by default, and I put #nullable disable in the SPDX licence file. The SPDX license update tool strips out that #nullable disable, so this PR annotates the PublicAPI txt files so it'll compile fine going forward.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@zivkan
zivkan requested a review from a team as a code owner November 21, 2025 06:01
@zivkan
zivkan requested review from jebriede and jeffkl November 21, 2025 06:01
@zivkan zivkan mentioned this pull request Nov 21, 2025
@zivkan
zivkan merged commit a8f3e53 into dev Nov 23, 2025
17 of 18 checks passed
@zivkan
zivkan deleted the dev-zivkan-spdx-nullable branch November 23, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.