cache NuGetEnvironment.GetFolderPath values - #6874
#6874Merged
zivkan merged 2 commits intoOct 24, 2025
devNuGet/NuGet.Client:devfrom
dev-zivkan-NuGetEnvironment-cachingNuGet/NuGet.Client:dev-zivkan-NuGetEnvironment-cachingCopy head branch name to clipboard
Merged
cache NuGetEnvironment.GetFolderPath values#6874zivkan merged 2 commits intodevNuGet/NuGet.Client:devfrom dev-zivkan-NuGetEnvironment-cachingNuGet/NuGet.Client:dev-zivkan-NuGetEnvironment-cachingCopy head branch name to clipboard
zivkan merged 2 commits into
devNuGet/NuGet.Client:devfrom
dev-zivkan-NuGetEnvironment-cachingNuGet/NuGet.Client:dev-zivkan-NuGetEnvironment-cachingCopy head branch name to clipboard
Conversation
jeffkl
previously approved these changes
Oct 20, 2025
nkolev92
previously approved these changes
Oct 20, 2025
zivkan
force-pushed
the
dev-zivkan-NuGetEnvironment-caching
branch
from
October 22, 2025 08:32
3e31837 to
a33d13c
Compare
jeffkl
approved these changes
Oct 24, 2025
This was referenced Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14602
Description
Every NuGetFolderPath value does at least one string.Concat, and some parts of NuGet call into NuGetEnvironment without implementing caching themselves. While the cache itself uses some memory, the overall memory allocations should be significantly improved.
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.N/A