Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use TargetAlias in AssetsFileDependencies snapshot - #6843

#6843
Merged
nkolev92 merged 3 commits into
devNuGet/NuGet.Client:devfrom
dev-nkolev92-useAliasInAssetsFileDependenciesSnapshotNuGet/NuGet.Client:dev-nkolev92-useAliasInAssetsFileDependenciesSnapshotCopy head branch name to clipboard
Oct 13, 2025
Merged

Use TargetAlias in AssetsFileDependencies snapshot#6843
nkolev92 merged 3 commits into
devNuGet/NuGet.Client:devfrom
dev-nkolev92-useAliasInAssetsFileDependenciesSnapshotNuGet/NuGet.Client:dev-nkolev92-useAliasInAssetsFileDependenciesSnapshotCopy head branch name to clipboard

Conversation

@nkolev92

@nkolev92 nkolev92 commented Oct 7, 2025

Copy link
Copy Markdown
Member

Bug

Fixes: NuGet/Home#14584

Description

Now that the reader "populates" the TargetAlias in LockFileTarget, we no longer need to do the look-up.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests - There are existing tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@nkolev92
nkolev92 marked this pull request as ready for review October 8, 2025 19:33
@nkolev92
nkolev92 requested a review from a team as a code owner October 8, 2025 19:33
@nkolev92
nkolev92 requested review from jebriede and jeffkl October 8, 2025 19:33
@nkolev92

Copy link
Copy Markdown
Member Author

@jeffkl @jebriede can I please get a review, thanks!

@nkolev92
nkolev92 merged commit 0c3b294 into dev Oct 13, 2025
17 of 18 checks passed
@nkolev92
nkolev92 deleted the dev-nkolev92-useAliasInAssetsFileDependenciesSnapshot branch October 13, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use TargetAlias in AssetsFileDependencies snapshot

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.