Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Migrate tests that are using the dependencies element - #6823

#6823
Merged
nkolev92 merged 7 commits into
devNuGet/NuGet.Client:devfrom
dev-nkolev92-removalOfDependenciesNuGet/NuGet.Client:dev-nkolev92-removalOfDependenciesCopy head branch name to clipboard
Oct 2, 2025
Merged

Migrate tests that are using the dependencies element#6823
nkolev92 merged 7 commits into
devNuGet/NuGet.Client:devfrom
dev-nkolev92-removalOfDependenciesNuGet/NuGet.Client:dev-nkolev92-removalOfDependenciesCopy head branch name to clipboard

Conversation

@nkolev92

@nkolev92 nkolev92 commented Oct 2, 2025

Copy link
Copy Markdown
Member

Bug

Progress: NuGet/Home#14446

Description

There are a bunch of tests that were still using the dependencies element, most of just declaring it.
This PR takes care of that.
Note that I did add some extra asserts, because some of these tests should've failed when the PackageSpec.Dependencies element stopped being merged in restore.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@nkolev92 nkolev92 added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Oct 2, 2025
@nkolev92 nkolev92 changed the title Removal of tests that are using the dependencies element Migrate tests that are using the dependencies element Oct 2, 2025
@nkolev92
nkolev92 marked this pull request as ready for review October 2, 2025 16:55
@nkolev92
nkolev92 requested a review from a team as a code owner October 2, 2025 16:55
@nkolev92
nkolev92 merged commit a979750 into dev Oct 2, 2025
17 of 18 checks passed
@nkolev92
nkolev92 deleted the dev-nkolev92-removalOfDependencies branch October 2, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Engineering Changes related to the build infrastructure of the repo and that do not change product code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.