Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use localized title for Package Source Mapping array setting - #6798

#6798
Merged
jeffkl merged 1 commit into
devNuGet/NuGet.Client:devfrom
dev-donnie-msft-usxLocStringNuGet/NuGet.Client:dev-donnie-msft-usxLocStringCopy head branch name to clipboard
Sep 23, 2025
Merged

Use localized title for Package Source Mapping array setting#6798
jeffkl merged 1 commit into
devNuGet/NuGet.Client:devfrom
dev-donnie-msft-usxLocStringNuGet/NuGet.Client:dev-donnie-msft-usxLocStringCopy head branch name to clipboard

Conversation

@donnie-msft

Copy link
Copy Markdown
Contributor

Bug

Fixes: NuGet/Home#14550

Description

The array setting title is typically suppressed if it matches the page's title.
However, I mistakenly left a hard-coded string here, so for localized languages, the hard-coded string was appearing as a heading for the array.
This PR matches the array title to the page title and therefore hides the array's header entirely for non en-US languages.

image image

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@donnie-msft
donnie-msft requested a review from a team as a code owner September 23, 2025 18:01
@jeffkl
jeffkl merged commit b046f0b into dev Sep 23, 2025
17 of 18 checks passed
@jeffkl
jeffkl deleted the dev-donnie-msft-usxLocString branch September 23, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Localization] The table title ‘Package Source Mapping’ in the ‘Options->NuGet Package Manager->Package Source Mapping’ page was not localized

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.