Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove RestoreTargetGraph.Name as it's redundant withg restoreTargetGaph.TargetGraphName being the widely used version - #6773

#6773
Merged
nkolev92 merged 1 commit into
devNuGet/NuGet.Client:devfrom
dev-nkolev92-removeUnusedAPINuGet/NuGet.Client:dev-nkolev92-removeUnusedAPICopy head branch name to clipboard
Sep 9, 2025
Merged

Remove RestoreTargetGraph.Name as it's redundant withg restoreTargetGaph.TargetGraphName being the widely used version#6773
nkolev92 merged 1 commit into
devNuGet/NuGet.Client:devfrom
dev-nkolev92-removeUnusedAPINuGet/NuGet.Client:dev-nkolev92-removeUnusedAPICopy head branch name to clipboard

Conversation

@nkolev92

@nkolev92 nkolev92 commented Sep 9, 2025

Copy link
Copy Markdown
Member

Bug

Fixes: NuGet/Home#14529

Description

With aliasing coming along soon, anything that generates an extra target graph name is a bit of tech debt because it's adding duplicate copies of the same code.

By removing this pretty much unused code, it just means when aliasing is implemented, the code switching between the impls will be simpler.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@nkolev92
nkolev92 requested a review from a team as a code owner September 9, 2025 01:35
@nkolev92
nkolev92 requested review from jeffkl and martinrrm September 9, 2025 01:35
…raph.TargetGraphName being the widely used version
@nkolev92
nkolev92 force-pushed the dev-nkolev92-removeUnusedAPI branch from 015a828 to f35cbcb Compare September 9, 2025 20:05
@nkolev92
nkolev92 enabled auto-merge (squash) September 9, 2025 20:05
@nkolev92
nkolev92 merged commit d3da51f into dev Sep 9, 2025
17 of 18 checks passed
@nkolev92
nkolev92 deleted the dev-nkolev92-removeUnusedAPI branch September 9, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove RestoreTargetGraph.Name as it's redundant with restoreTargetGraph.TargetGraphName being the widely used version

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.