No longer show a page-level error when enabling a duplicate package source - #6745
#6745Merged
donnie-msft merged 2 commits intoSep 2, 2025
devNuGet/NuGet.Client:devfrom
dev-donnie-msft-usxHandleDuplicateEnabledNuGet/NuGet.Client:dev-donnie-msft-usxHandleDuplicateEnabledCopy head branch name to clipboard
Merged
No longer show a page-level error when enabling a duplicate package source#6745donnie-msft merged 2 commits intodevNuGet/NuGet.Client:devfrom dev-donnie-msft-usxHandleDuplicateEnabledNuGet/NuGet.Client:dev-donnie-msft-usxHandleDuplicateEnabledCopy head branch name to clipboard
donnie-msft merged 2 commits into
devNuGet/NuGet.Client:devfrom
dev-donnie-msft-usxHandleDuplicateEnabledNuGet/NuGet.Client:dev-donnie-msft-usxHandleDuplicateEnabledCopy head branch name to clipboard
Conversation
jebriede
approved these changes
Aug 29, 2025
jebriede
left a comment
Contributor
There was a problem hiding this comment.
Approving with suggestion!
zivkan
approved these changes
Aug 29, 2025
donnie-msft
force-pushed
the
dev-donnie-msft-usxHandleDuplicateEnabled
branch
from
September 2, 2025 12:36
ac7df86 to
4847a81
Compare
donnie-msft
enabled auto-merge (squash)
September 2, 2025 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14499
Description
Removes NuGet's VS Options implementation validating uniqueness of sources and therefore allows a duplicate source to become enabled. The Unified Settings registration.json enforces uniqueness by the declaration:
"uniqueness": "caseInsensitive"Removing this enables the scenario in the Issue, and as described below:
Starting with the scenario of a duplicate source that is not enabled:
After checking the box to enable this package source, the source is enabled in the NuGet.Config, and no page-level error occurs. The item-level error is still shown:
Created a follow-up tracking changes that Unified Settings may make in NuGet/Home#14507.
We will either bring the validation back at the array-item level or remove it and use a configurable uniqueness check that can consider Enabled sources.
PR Checklist